[libc-commits] [libc] bf6f389 - [libc] Fix warnings on release build.

[Paula Toth via libc-commits]

Author: Paula Toth
Date: 2020-05-07T11:56:11-07:00
New Revision: bf6f3894c4a8f7572e8c45d28d6c5c0fa6101a90

URL: https://github.com/llvm/llvm-project/commit/bf6f3894c4a8f7572e8c45d28d6c5c0fa6101a90
DIFF: https://github.com/llvm/llvm-project/commit/bf6f3894c4a8f7572e8c45d28d6c5c0fa6101a90.diff

LOG: [libc] Fix warnings on release build.

Summary:
These warnings were present when building llvm-libc in release mode.

```
workspace/llvm-project/libc/utils/benchmarks/LibcMemoryBenchmarkTest.cpp:50:34: warning: 'None' is deprecated: Use Align() or Align(1) instead [-Wdeprecated-declarations]
  Conf.AddressAlignment = Align::None();

workspace/llvm-project/libc/utils/testutils/FDReaderUnix.cpp:19:7: warning: unused variable 'err' [-Wunused-variable]
  int err = ::pipe(pipefd);
```

For test-utils it seems in general we should use `report_fatal_error` instead of asserts as these are turned off when building in release mode.
https://llvm.org/docs/CodingStandards.html#assert-liberally

Reviewers: abrachet, sivachandra

Reviewed By: abrachet, sivachandra

Subscribers: tschuett, libc-commits

Tags: #libc-project

Differential Revision: https://reviews.llvm.org/D79469

Added: 
    

Modified: 
    libc/utils/benchmarks/LibcMemoryBenchmarkTest.cpp
    libc/utils/testutils/FDReaderUnix.cpp

Removed: 
    


################################################################################
diff  --git a/libc/utils/benchmarks/LibcMemoryBenchmarkTest.cpp b/libc/utils/benchmarks/LibcMemoryBenchmarkTest.cpp
index 2abd6495262d..58d9bbf45dea 100644
--- a/libc/utils/benchmarks/LibcMemoryBenchmarkTest.cpp
+++ b/libc/utils/benchmarks/LibcMemoryBenchmarkTest.cpp
@@ -47,7 +47,6 @@ TEST(OffsetDistribution, AlignToBegin) {
 TEST(OffsetDistribution, NoAlignment) {
   StudyConfiguration Conf;
   Conf.BufferSize = 8192;
-  Conf.AddressAlignment = Align::None();
   Conf.Size.To = 1;
 
   OffsetDistribution OD(Conf);

diff  --git a/libc/utils/testutils/FDReaderUnix.cpp b/libc/utils/testutils/FDReaderUnix.cpp
index 943d3eb5356e..c54a1a423d86 100644
--- a/libc/utils/testutils/FDReaderUnix.cpp
+++ b/libc/utils/testutils/FDReaderUnix.cpp
@@ -16,8 +16,8 @@ namespace __llvm_libc {
 namespace testutils {
 
 FDReader::FDReader() {
-  int err = ::pipe(pipefd);
-  assert(!err && "pipe(2) failed");
+  if (::pipe(pipefd))
+    llvm::report_fatal_error("pipe(2) failed");
 }
 
 FDReader::~FDReader() {