[libc-commits] [PATCH] D79149: [libc] Move implementations of expf and exp2f from the AOR to src/math.

[Alex Brachet via Phabricator via libc-commits]

abrachet added inline comments.


================
Comment at: libc/src/math/exp2f.cpp:17-19
+#define T exp2f_data.tab
+#define C exp2f_data.poly
+#define SHIFT exp2f_data.shift_scaled
----------------
These are only used once or twice and we just expand these manually?


================
Comment at: libc/src/math/exp2f.cpp:26
+  uint64_t ki, t;
+  /* double_t for better performance on targets with FLT_EVAL_METHOD==2.  */
+  double_t kd, xd, z, r, r2, y, s;
----------------
We probably want these to be `//`


================
Comment at: libc/src/math/exp2f.h:1-2
+//===-- Implementation header for exp2f --------------------------*- C++
+//-*-===//
+//
----------------
Classic clang-format


================
Comment at: libc/src/math/exp2f.h:10-11
+
+#ifndef LLVM_LIBC_SRC_MATH_SINF_H
+#define LLVM_LIBC_SRC_MATH_SINF_H
+
----------------
MATH_EXP2F


================
Comment at: libc/src/math/exp_utils.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
Missing comment


================
Comment at: libc/src/math/expf.h:9-11
+#ifndef LLVM_LIBC_SRC_MATH_SINF_H
+#define LLVM_LIBC_SRC_MATH_SINF_H
+
----------------
MATH_EXPF


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79149/new/

https://reviews.llvm.org/D79149