[libc-commits] [PATCH] D79256: [libc] Improve information printed on failure of a math test which uses MPFR.
Siva Chandra via Phabricator via libc-commits
libc-commits at lists.llvm.org
Mon May 4 15:37:30 PDT 2020
sivachandra added inline comments.
================
Comment at: libc/utils/CPP/TypeTraits.h:50-52
+template <typename T> struct RemoveCV<const T> { typedef T type; };
+template <typename T> struct RemoveCV<volatile T> { typedef T type; };
+template <typename T> struct RemoveCV<const volatile T> { typedef T type; };
----------------
abrachet wrote:
> `type` -> `Type`
>
> On that note, we could make an analog to `std::type_identity` and make this
> `template <typename T> struct RemoveCV : TypeIdentity<T> {};`. No strong preference though.
At the least it avoid typos like the one you found. So, done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79256/new/
https://reviews.llvm.org/D79256
More information about the libc-commits
mailing list