[libc-commits] [PATCH] D79256: [libc] Improve information printed on failure of a math test which uses MPFR.

[Siva Chandra via Phabricator via libc-commits]

sivachandra added a comment.

In D79256#2016625 <https://reviews.llvm.org/D79256#2016625>, @abrachet wrote:

> I don't want to make any suggestions yet because I don't fully understand why we need a `MPFR_TEST`. Would you mind clarifying the need for `TEST_WITH_BASE_CLASS`? Instead of `MPFR_TEST` could we have `TEST_EXTENSION`'s first argument take a class with `compare`, would that simplify it? I'm by no means a gtest expert, I'm not sure how someone would use gtest to fill these kinds of needs. Maybe they would make their own macros which end up calling `FAIL` or using matchers. We aren't limited to that though so perhaps these would end up being more complicated than this solution.


Huh! I totally missed that we have matchers now with which we can do the exact same thing as in this patch. Will change it to use the matcher API and update soon.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79256/new/

https://reviews.llvm.org/D79256