[libc-commits] [PATCH] D76978: [libc builder] Add custom step to run clang-tidy.

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: zorg/buildbot/builders/annotated/libc-linux.py:43
+        run_command(['ninja', 'clang-tidy'])
+    with step('run clang-tidy'):
+        tidy_glob = os.path.join(source_dir,'libc', 'src', '**', '**.cpp')
----------------
sivachandra wrote:
> But, running clang tidy should be driven by our build rules.
I would actually add that not all builders should run clang tidy. We should have an implementation standard checker builder which runs clang-tidy as part of building everything under llvmlibc. This builder should not run tests. This scheme will allow us to reduce builder cycle time. About how to do this, we can drive it via some CMake option: default behavior is to run clang-tidy as part of our build rules, while on all but one builder we disable implementation standard checking via the CMake option.


Repository:
  rZORG LLVM Github Zorg

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76978/new/

https://reviews.llvm.org/D76978