[libc-commits] [libc] 255e634 - [libc][NFC] Ensure internal implementation is in __llvm_libc namespace

Alex Brachet via libc-commits libc-commits at lists.llvm.org
Sat Mar 28 00:00:02 PDT 2020


Author: Alex Brachet
Date: 2020-03-28T02:59:42-04:00
New Revision: 255e634bf71a2e7cf128c93090717183fba1666a

URL: https://github.com/llvm/llvm-project/commit/255e634bf71a2e7cf128c93090717183fba1666a
DIFF: https://github.com/llvm/llvm-project/commit/255e634bf71a2e7cf128c93090717183fba1666a.diff

LOG: [libc][NFC] Ensure internal implementation is in __llvm_libc namespace

Summary: In preparation for D76818.

Reviewers: PaulkaToast, sivachandra, gchatelet

Reviewed By: PaulkaToast, sivachandra

Subscribers: MaskRay, tschuett, libc-commits

Differential Revision: https://reviews.llvm.org/D76967

Added: 
    

Modified: 
    libc/src/signal/linux/__restore.cpp
    libc/src/string/memory_utils/memcpy_utils.h
    libc/src/threads/linux/thread_utils.h

Removed: 
    


################################################################################
diff  --git a/libc/src/signal/linux/__restore.cpp b/libc/src/signal/linux/__restore.cpp
index bfdee4bab1c3..8d99d6abb014 100644
--- a/libc/src/signal/linux/__restore.cpp
+++ b/libc/src/signal/linux/__restore.cpp
@@ -13,8 +13,12 @@
 #include "config/linux/syscall.h"
 #include "include/sys/syscall.h"
 
+namespace __llvm_libc {
+
 extern "C" void __restore_rt()
     __attribute__((no_sanitize("thread", "memory", "undefined", "fuzzer"),
                    hidden));
 
 extern "C" void __restore_rt() { __llvm_libc::syscall(SYS_rt_sigreturn); }
+
+} // namespace __llvm_libc

diff  --git a/libc/src/string/memory_utils/memcpy_utils.h b/libc/src/string/memory_utils/memcpy_utils.h
index c69e557574c0..7975d474d2f6 100644
--- a/libc/src/string/memory_utils/memcpy_utils.h
+++ b/libc/src/string/memory_utils/memcpy_utils.h
@@ -20,14 +20,14 @@
 #define USE_BUILTIN_MEMCPY
 #endif
 
+namespace __llvm_libc {
+
 // This is useful for testing.
 #if defined(LLVM_LIBC_MEMCPY_MONITOR)
 extern "C" void LLVM_LIBC_MEMCPY_MONITOR(char *__restrict,
                                          const char *__restrict, size_t);
 #endif
 
-namespace __llvm_libc {
-
 // Copies `kBlockSize` bytes from `src` to `dst`.
 template <size_t kBlockSize>
 static void Copy(char *__restrict dst, const char *__restrict src) {

diff  --git a/libc/src/threads/linux/thread_utils.h b/libc/src/threads/linux/thread_utils.h
index e9dfb4c29de9..37198ad0afb4 100644
--- a/libc/src/threads/linux/thread_utils.h
+++ b/libc/src/threads/linux/thread_utils.h
@@ -14,6 +14,8 @@
 #include <stdatomic.h>
 #include <stdint.h>
 
+namespace __llvm_libc {
+
 // The futex data has to be exactly 4 bytes long. However, we use a uint type
 // here as we do not want to use `_Atomic uint32_t` as the _Atomic keyword which
 // is C only. The header stdatomic.h does not define an atomic type
@@ -35,4 +37,6 @@ struct ThreadParams {
   static constexpr uint32_t ClearTIDValue = 0xABCD1234;
 };
 
+} // namespace __llvm_libc
+
 #endif // LLVM_LIBC_SRC_THREADS_LINUX_THREAD_UTILS_H


        


More information about the libc-commits mailing list