[libc-commits] [PATCH] D76967: [libc][NFC] Ensure internal implementation is in __llvm_libc namespace

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Mar 27 23:57:53 PDT 2020


sivachandra added a comment.

In D76967#1947538 <https://reviews.llvm.org/D76967#1947538>, @sivachandra wrote:

> In D76967#1947520 <https://reviews.llvm.org/D76967#1947520>, @MaskRay wrote:
>
> > Delete all occurrences of `__llvm_libc`.
>
>
> We made a decision to start with this, so we will stick with it unless we find some absolutely no go situation.


BTW, some of the reasons have been outlined in previous patches and discussions. For example, being able to mix with other libc implementations. There are possibly other ways to do it. Decision on using namespaces as a solution has already been made so we will stick with it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76967/new/

https://reviews.llvm.org/D76967





More information about the libc-commits mailing list