[libc-commits] [PATCH] D76676: [libc] Unblock SIGABRT before raising in abort
Siva Chandra via Phabricator via libc-commits
libc-commits at lists.llvm.org
Thu Mar 26 21:44:48 PDT 2020
sivachandra added inline comments.
Comment at: libc/src/stdlib/abort.cpp:39
+ __llvm_libc::signal(SIGABRT, SIG_DFL);
> Aside from the multi-thread case, I think there is a single thread re-entry issue here. A signal can be raised in between the execution of this line and the previous line (e.g. from an external program or alarm) that installs the default handler. A possible solution might be to block all signals for this segment?
That's a good point. We can get creative with some locking may be to test this?
CHANGES SINCE LAST ACTION
More information about the libc-commits