[libc-commits] [PATCH] D76825: [libc] Move implementations of cosf, sinf, sincosf to src/math directory.

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Mar 26 11:59:14 PDT 2020

sivachandra added a comment.

In D76825#1942971 <https://reviews.llvm.org/D76825#1942971>, @abrachet wrote:

> It's probably worth discussing how much we expect we will alter these files. Is it fine to just accept that we didn't write them and that they will just be very different from the rest of libc?

While I do intend to make any functional changes in this move patch, we absolutely want the code to follow our implementation standards, just like the rest of the code. So, thanks for already pointing out the items missed. For now, all I have done was to run clang-format. I will fix the rest with a new upload.

  rG LLVM Github Monorepo



More information about the libc-commits mailing list