[libc-commits] [PATCH] D76412: [libc] Add a simple x86_64 linux loader.

[Siva Chandra via Phabricator via libc-commits]

sivachandra marked 3 inline comments as done.
sivachandra added inline comments.


================
Comment at: libc/test/loader/CMakeLists.txt:62
+    POST_BUILD
+    COMMAND sh -c ${ADD_LOADER_TEST_ENV} $<TARGET_FILE:${target_name}> ${ADD_LOADER_TEST_ARGS}
+  )
----------------
abrachet wrote:
> phosek wrote:
> > This is likely going to fail on any non-POSIX systems since there likely won't be `sh` available, should we print a warning in that case?
> I just tried this with `fish` (the one I described as not accepting the syntax `VAR=value`) and it worked just fine. Removing `sh -c`, is fine then. I'm guessing though that you are saying the syntax `VAR=value` wont work in this case?
I removed the `sh -c` now and added a warning at the beginning of this function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76412/new/

https://reviews.llvm.org/D76412