[libc-commits] [PATCH] D76723: [libc] Generate math.h instead of the static file it is currently.

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Mar 24 14:34:12 PDT 2020


sivachandra marked 2 inline comments as done.
sivachandra added inline comments.


================
Comment at: libc/spec/stdc.td:181-182
       [
-          FunctionSpec<"acos", RetValSpec<DoubleType>, [ArgSpec<DoubleType>]>,
-          FunctionSpec<"acosl", RetValSpec<LongDoubleType>, [ArgSpec<LongDoubleType>]>,
+          FunctionSpec<"cosf", RetValSpec<FloatType>, [ArgSpec<FloatType>]>,
+          FunctionSpec<"sinf", RetValSpec<FloatType>, [ArgSpec<FloatType>]>,
+
----------------
abrachet wrote:
> Should we include these even though we have no implementation of them?
Good point. Will add them in the patch adding their implementation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76723/new/

https://reviews.llvm.org/D76723





More information about the libc-commits mailing list