[libc-commits] [PATCH] D76536: [libc] Add signal

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra marked an inline comment as done.
sivachandra added inline comments.


================
Comment at: libc/spec/stdc.td:19
 
+  NamedType SigHandlerT = NamedType<"sighandler_t">;
+
----------------
abrachet wrote:
> sivachandra wrote:
> > Neither POSIX nor std C prescribe it. Is it present merely as a convenience or because there is no way to describe function types using tablegen? Either way, I think this is OK. But to avoid name pollution, we should name this type with `__` prefix.
> Will you take another look to make sure its ok? Specifically that I put the `using sighandler_t = __sighandler_t` in `src/signal/signal.h` inside `__llvm_libc`.
LGTM


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76536/new/

https://reviews.llvm.org/D76536