[libc-commits] [PATCH] D76559: [libc] Enable llvmlibc clang-tidy checks

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added a comment.

This is OK as a start. But, can we follow up with a study on running clang-tidy as part of our build rules? Like, what are the pros and cons? For the pros, I can think of:

1. We will not require `NOLINT...` annotations for redirectors.
2. Generated headers can be checked.
3. We force checks as part of our development workflow.

For cons, our builds will now depend on clang and clang-tools-extra. May be there are ways to reduce the "burden".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76559/new/

https://reviews.llvm.org/D76559