[libc-commits] [PATCH] D76412: [libc] Add a simple x86_64 linux loader.
Fangrui Song via Phabricator via libc-commits
libc-commits at lists.llvm.org
Fri Mar 20 09:11:04 PDT 2020
MaskRay added a comment.
In D76412#1932808 <https://reviews.llvm.org/D76412#1932808>, @sivachandra wrote:
> In D76412#1932339 <https://reviews.llvm.org/D76412#1932339>, @MaskRay wrote:
> > The directory structure `libc/loader/linux/x86_64/` does not seem very right. A loader can be made architecture agnostic with a little abstraction. I am concerned this will get copied over to x86 and aarch64.
> I agree. This patch is really simple, mostly focusing on the infrastructure. For future patches, I intend to cater to both i386 and x86_64, so some sort of abstraction will be incorporated to handle common code.
I hope we won't leave that in the future. This can simply be improved now.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libc-commits