[libc-commits] [PATCH] D76412: [libc] Add a simple x86_64 linux loader.

[Fangrui Song via Phabricator via libc-commits]

MaskRay added a comment.

The directory structure `libc/loader/linux/x86_64/` does not seem very right. A loader can be made architecture agnostic with a little abstraction. I am concerned this will get copied over to x86 and aarch64.



================
Comment at: libc/loader/linux/x86_64/CMakeLists.txt:10
+    -fno-omit-frame-pointer
+    -w # For one, we call main which is not allowed by the C++ standard.
+)
----------------
This does not seem correct. clang -Wall -Wextra does not warn on calling main.
You could use `#pragma GCC diagnostic ignored` if they really warned. More so, such a warning would not be emitted in -ffreestanding mode.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76412/new/

https://reviews.llvm.org/D76412