[libc-commits] [PATCH] D76271: [libc] Add a new rule `add_object`.

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Mar 17 12:57:08 PDT 2020


sivachandra marked an inline comment as done.
sivachandra added inline comments.


================
Comment at: libc/cmake/modules/LLVMLibCRules.cmake:134
+  endif()
+  if(ADD_OBJECT_NAME)
+    set_target_properties(
----------------
Looks like object libraries don't give us the flexibility to customize the location and name of the generated object files. I will submit after removing lines 134 to 146 which seem to be doing nothing for an object library.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76271/new/

https://reviews.llvm.org/D76271





More information about the libc-commits mailing list