[libc-commits] [PATCH] D74397: [libc] Adding memcpy implementation for x86_64

Guillaume Chatelet via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Mar 13 14:34:15 PDT 2020

gchatelet added a comment.

This last modification does not change the memcpy implementation but how we detect cpu features and how we build/test the memcpy implementations.
There are less global variables only `ALL_CPU_FEATURES` and `HOST_CPU_FEATURES`.
The flags are built through `compute_flags` and host compatibility tested with `host_supports`.
All memcpy implementations are added to a global property to be passed down to tests.
Tests can query the target for their required cpu features and test the host against them, hence testing only the implementations that the host can execute.
This also remove the need for individual check files.

Overall I think the design is much simpler and straightforward.

  rG LLVM Github Monorepo



More information about the libc-commits mailing list