[libc-commits] [PATCH] D75596: [libc] Add docker container for llvm-libc buildbot worker.

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/utils/buildbot/Dockerfile:10
+
+# Grabbing fresh ninja.
+RUN cd /tmp && git clone https://github.com/martine/ninja.git \
----------------
Is there a reason why we cannot use stock ninja?


================
Comment at: libc/utils/buildbot/Dockerfile:11
+# Grabbing fresh ninja.
+RUN cd /tmp && git clone https://github.com/martine/ninja.git \
+  && cd ninja && git checkout release && ./bootstrap.py \ 
----------------
If we do want the most recent release branch, we should probably use the official URL.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75596/new/

https://reviews.llvm.org/D75596