[libc-commits] [PATCH] D75802: [libc] Add sigaction

[Fangrui Song via Phabricator via libc-commits]

MaskRay added inline comments.


================
Comment at: libc/src/signal/linux/arch/__restore_rt_x86_64.S:21
+
+.intel_syntax noprefix
+.text
----------------
Delete them.


================
Comment at: libc/src/signal/linux/arch/__restore_rt_x86_64.S:24
+
+// This nop works around a gdb bug to make sure it doesn't confuse this function
+// with the function right behind it.
----------------
There needs to be a reference to musl/src/signal/x86_64/restore.s commit 54991729 unless I am mistaken.

Can you figure out whether the gdb bug has been fixed?


================
Comment at: libc/src/signal/linux/arch/__restore_rt_x86_64.S:33
+    syscall
+__restore_rt_end:
+.size __restore_rt,__restore_rt_end-__restore_rt
----------------
Use `.` instead of an end symbol. The end symbol wastes a symbol table entry.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75802/new/

https://reviews.llvm.org/D75802