[libc-commits] [PATCH] D75651: [libc] [UnitTest] Add timeout to death tests

Paula Toth via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Mar 5 09:51:04 PST 2020


PaulkaToast marked an inline comment as done.
PaulkaToast added inline comments.


================
Comment at: libc/utils/testutils/ExecuteFunctionUnix.cpp:64
+    ::kill(Pid, SIGKILL);
+    return ProcessStatus::Error("Process timed out");
+  }
----------------
I think it'd be useful to include the length of the timeout in the error message.
e.g "Process timed out after 500ms"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75651/new/

https://reviews.llvm.org/D75651





More information about the libc-commits mailing list