[libc-commits] [PATCH] D75651: [libc] [UnitTest] Add timeout to death tests

Alex Brachet via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Mar 4 17:27:08 PST 2020

abrachet marked an inline comment as done.
abrachet added inline comments.

Comment at: libc/utils/testutils/ExecuteFunction.h:25
-  bool exitedNormally();
-  int getExitCode();
-  int getFatalSignal();
+  static ProcessStatus Error(const char *Error) { return {0, Error}; }
MaskRay wrote:
> I think for new projects, we don't have to use `VariableName`. We should use the ideal case `variableName`.
> https://llvm.org/docs/Proposals/VariableNames.html Everyone agrees that the current `VariableName` convention is broken. People have concerns with existing code base because renaming can clutter up the history. But for a new project, there is simply not meaningful to start with `VariableName`.
Ok I will change the variables that I created in this patch. Did Rui upstream the tool he used to convert lld's code base so that I could use it here?



More information about the libc-commits mailing list