[libc-commits] [PATCH] D75420: [libc] Add initial assert definition

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Sun Mar 1 22:46:23 PST 2020

sivachandra added a comment.

Did not do a proper review. Left couple of very high level comments.

Comment at: libc/src/assert/__assert_fail.cpp:1
+//===----------------- Implementation of __assert_fail --------------------===//
Looks like this is a linux only solution so should sit in a linux specific area. Or, is it because it is a temporary solution, and you envision that the final implementation would use `stderr` and make it platform independent?

Comment at: libc/src/assert/__assert_fail.cpp:19
+// This is just a temporary solution to make assert available to internal
+// llvm libc code.
Can you add to the comment how the final solution is going to look like?



More information about the libc-commits mailing list