[libc-commits] [PATCH] D75427: [libc] Add llvm-lit testing infrastructure

[Alex Brachet via Phabricator via libc-commits]

abrachet marked 3 inline comments as done.
abrachet added inline comments.


================
Comment at: libc/test/test/lit.cfg.py:49
+config.substitutions.append(
+    ('%clang_libc', 'clang -nostdinc -isystem '
+        + findLibcIncDir() + ' ' + findLibcDotA()))
----------------
I just realized I should use CMAKE_C_COMPILER in lit.site.cfg.py.in instead of just using clang, I will do that in the next round.


================
Comment at: libc/test/test/sanity/includes.c:9
+// build's include directory.
+#include <errno.h>
+#include <math.h>
----------------
This one also fails currently because <linux/errno.h> is not found because %clang_libc compiles with `-nostdinc`


================
Comment at: libc/test/test/src/assert/assert.c:1
+// This tests that asserts error message is as we expect.
+
----------------
This test is erroneous because it is linking against glibc's `__assert_fail` not ours. Which is surprising because __assert_fail is in libllvmlibc.a. I'm not sure why ld is not linking against libllvmlibc.a's `__assert_fail`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75427/new/

https://reviews.llvm.org/D75427