[libc-commits] [PATCH] D82591: [libc] Add the remaining long double flavors of nearest integer functions.

[Anthony Steinhauser via Phabricator via libc-commits]

asteinhauser accepted this revision.
asteinhauser added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/test/src/math/ceill_test.cpp:23
+TEST(CeillTest, SpecialNumbers) {
+  ASSERT_TRUE(FPBits::zero() == __llvm_libc::ceill(FPBits::zero()));
+  ASSERT_TRUE(FPBits::negZero() == __llvm_libc::ceill(FPBits::negZero()));
----------------
ASSERT_EQ(a, b) here and in the all following ASSERT_TRUE(a == b).


================
Comment at: libc/test/src/math/ceill_test.cpp:30
+  long double nan = FPBits::buildNaN(1);
+  ASSERT_TRUE(isnan(nan) != 0);
+  ASSERT_TRUE(isnan(__llvm_libc::ceill(nan)) != 0);
----------------
ASSERT_TRUE(a) instead of ASSERT_TRUE(a != 0). Eventually use ASSERT_NE(a, 0) if 0 does not autoconvert to false.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82591/new/

https://reviews.llvm.org/D82591