[libc-commits] [PATCH] D82247: [libc] Add fuzz test for strcmp.

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Jun 22 21:29:34 PDT 2020


sivachandra accepted this revision.
sivachandra marked an inline comment as done.
sivachandra added a comment.

OK after addressing Paula's comments.



================
Comment at: libc/fuzzing/string/strcmp_fuzz.cpp:13
+#include "src/string/strcmp.h"
+#include <algorithm>
+#include <stdint.h>
----------------
I see Paula's comment related to this but I would like to drive this more strongly: The only headers not part of LLVM libc that are OK to include are the freestanding C headers, and the headers provided by the compiler (like `stdatomic.h`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82247/new/

https://reviews.llvm.org/D82247





More information about the libc-commits mailing list