[libc-commits] [PATCH] D81029: [libc] Remove integration test target from check libc.

[Paula Toth via Phabricator via libc-commits]

PaulkaToast created this revision.
PaulkaToast added a reviewer: sivachandra.
PaulkaToast added a project: libc-project.
Herald added subscribers: libc-commits, ecnelises, tschuett, mgorny.
sivachandra accepted this revision.
sivachandra added a comment.
This revision is now accepted and ready to land.
PaulkaToast updated this revision to Diff 267969.

s/check-libc-public-integration/libc-integration-test

It is cleaner, and easy to remember.


This is failing on the asan build because we use `-nostdlib`.
I also took this opportunity to make the target name match the naming structure we've been using.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D81029

Files:
  libc/test/src/CMakeLists.txt


Index: libc/test/src/CMakeLists.txt
===================================================================
--- libc/test/src/CMakeLists.txt
+++ libc/test/src/CMakeLists.txt
@@ -38,32 +38,32 @@
 )
 
 add_executable(
-  public_integration_test
+  libc-integration-test
   EXCLUDE_FROM_ALL
   ${public_test}
 )
 # Blank out default include directories to prevent accidentally including
 # system headers or our own internal headers.
 set_target_properties(
-  public_integration_test
+  libc-integration-test
   PROPERTIES
   INCLUDE_DIRECTORIES ""
 )
 # Only include we need is the include for cpp::IsSame and our generated
 # public headers.
 target_include_directories(
-  public_integration_test BEFORE
+  libc-integration-test BEFORE
   PRIVATE
     "${LIBC_SOURCE_DIR}/utils/CPP"
     "${LIBC_BUILD_DIR}/include"
 )
 target_compile_options(
-  public_integration_test
+  libc-integration-test
   PRIVATE
   -ffreestanding
 )
 target_link_options(
-  public_integration_test
+  libc-integration-test
   PRIVATE "-nostdlib"
 )
 set(library_files)
@@ -74,7 +74,7 @@
 
 if(COMPILER_RESOURCE_DIR AND LLVM_LIBC_ENABLE_LINTING)
   add_custom_target(
-    public_integration_test-tidy
+    libc-integration-test-tidy
     VERBATIM
     COMMAND $<TARGET_FILE:clang-tidy> --system-headers
       --checks=-*,llvmlibc-restrict-system-libc-headers
@@ -88,11 +88,10 @@
     DEPENDS
       clang-tidy ${public_test}
   )
-  add_dependencies(check-libc public_integration_test-tidy)
+  add_dependencies(libc-integration-test libc-integration-test-tidy)
 endif()
 
-target_link_libraries(public_integration_test
+target_link_libraries(libc-integration-test
   PRIVATE
   ${library_files}
 )
-add_dependencies(check-libc public_integration_test)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81029.267969.patch
Type: text/x-patch
Size: 1729 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20200602/7fcc140a/attachment.bin>