[libc-commits] [PATCH] D79192: [libc] Add integration tests.

[Paula Toth via Phabricator via libc-commits]

PaulkaToast marked an inline comment as done.
PaulkaToast added a comment.





================
Comment at: libc/test/src/CMakeLists.txt:96
+  PRIVATE
+  ${library_files}
+)
----------------
sivachandra wrote:
> Why not include the loader here?
Yes, this will be incorporated in part 2, as per this comment. 

https://reviews.llvm.org/D79192#2027676
> I think we should be complete here. Lets split this change into two changes:
> 1. First change will add a target to build the main object but not the full executable. In this change, we will make use of clang-tidy to ensure only LLVM-libc or platform or compiler headers are being included.
> 2. Second change will add a target to link this main object with the loader object making it a true integration test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79192/new/

https://reviews.llvm.org/D79192