[libc-commits] [PATCH] D84960: [libc] Adds islower, isupper. Uses EXPECT_EQ/NE in ctype function tests.

Chris Gyurgyik via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Jul 30 11:18:44 PDT 2020


cgyurgyik created this revision.
cgyurgyik added a reviewer: sivachandra.
Herald added subscribers: libc-commits, ecnelises, tschuett, mgorny.
Herald added a project: libc-project.
cgyurgyik requested review of this revision.

[libc] Adds islower, isupper implementation.

Replaces EXPECT_TRUE/FALSE with EXPECT_EQ/NE. I originally chose the former because a function named is* and boolean values go together well. However, with the simplicity of ctype functions, it is not really necessary to force this cast.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D84960

Files:
  libc/config/linux/aarch64/entrypoints.txt
  libc/config/linux/api.td
  libc/config/linux/x86_64/entrypoints.txt
  libc/spec/stdc.td
  libc/src/ctype/CMakeLists.txt
  libc/src/ctype/islower.cpp
  libc/src/ctype/islower.h
  libc/src/ctype/isupper.cpp
  libc/src/ctype/isupper.h
  libc/test/src/ctype/CMakeLists.txt
  libc/test/src/ctype/isalnum_test.cpp
  libc/test/src/ctype/isalpha_test.cpp
  libc/test/src/ctype/isdigit_test.cpp
  libc/test/src/ctype/islower_test.cpp
  libc/test/src/ctype/isupper_test.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84960.281975.patch
Type: text/x-patch
Size: 11337 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20200730/e622a3d6/attachment-0001.bin>


More information about the libc-commits mailing list