[libc-commits] [PATCH] D84893: [libc] Implements isdigit and isalnum.

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Jul 29 22:56:49 PDT 2020


sivachandra added a comment.

Overall LGTM. To avoid call instructions to other classification functions, for example `isalnum` calls `isdigit` and or `isalpha` does it make sense to have a library of `static inline` implementations in a header file. Then, the implementation functions will call the `static inline` functions, but the call overhead is avoided because of them being `static inline`. WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84893/new/

https://reviews.llvm.org/D84893



More information about the libc-commits mailing list