[libc-commits] [PATCH] D84469: [libc] Adds implementation for memrchr.

[Chris Gyurgyik via Phabricator via libc-commits]

cgyurgyik marked an inline comment as done.
cgyurgyik added inline comments.


================
Comment at: libc/src/string/memrchr.cpp:18
+  const unsigned char ch = c;
+  while (n--) {
+    if (str[n] == ch)
----------------
sivachandra wrote:
> For better readability, may be:
> 
> ```
> for (; n != 0; --n) {
>   ...
> }
> ```
Are you looking for something along these lines:
```
for (; n != 0; --n) {
      if (str[n] == ch) return const_cast<unsigned char *>(str + n);
  }
  return str[0] == ch ? const_cast<unsigned char *>(str) : nullptr;
```
Or, am I missing something simpler here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84469/new/

https://reviews.llvm.org/D84469