[libc-commits] [PATCH] D84385: [libc] Add implementations of fmax, fmaxf, and fmaxl.

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/src/math/fmaxf.cpp:19
+} // namespace __llvm_libc
\ No newline at end of file

----------------
New line?


================
Comment at: libc/test/src/math/fmax_test.cpp:9
+
+#include <vector>
+
----------------
Do we need this? Looks like they are present in the fmin tests as well. You can take them out in a separate obvious patch if they are not required.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84385/new/

https://reviews.llvm.org/D84385