[libc-commits] [PATCH] D83956: [libc] Add strstr implementation.

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Jul 20 23:11:09 PDT 2020


sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/src/string/strstr.cpp:16
+
+// TODO: This is a simple brute force implementation. This can (and will) be
+// improved upon using well known string matching algorithms.
----------------
Nitty comment on a comment: Remove `(and will)` :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83956/new/

https://reviews.llvm.org/D83956





More information about the libc-commits mailing list