[libc-commits] [PATCH] D83956: [libc] Add strstr implementation.

[Chris Gyurgyik via Phabricator via libc-commits]

cgyurgyik marked 3 inline comments as done.
cgyurgyik added inline comments.


================
Comment at: libc/src/string/strstr.cpp:17
+
+// TODO: This is a simple brute force implementation that uses strlen.
+// This can (and will) be improved upon using well known string matching
----------------
sivachandra wrote:
> You shouldn't need `strlen` even for a brute force implementation unless a future update will call `strlen`. Even then, doesn't seem like using `strlen` should be used until we really need it.
You're right. Fixed, thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83956/new/

https://reviews.llvm.org/D83956