[libc-commits] [PATCH] D83980: [libc][NFC] Use RemoveCVType to implement IsIntegral.

[Siva Chandra via Phabricator via libc-commits]

sivachandra updated this revision to Diff 278634.
sivachandra added a comment.

- Add IsSameV
- Use RemoveCV for IsPointerType as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83980/new/

https://reviews.llvm.org/D83980

Files:
  libc/utils/CPP/TypeTraits.h


Index: libc/utils/CPP/TypeTraits.h
===================================================================
--- libc/utils/CPP/TypeTraits.h
+++ libc/utils/CPP/TypeTraits.h
@@ -26,27 +26,12 @@
   static constexpr bool Value = false;
 };
 
-template <typename Type> struct IsIntegral : public FalseValue {};
-template <> struct IsIntegral<char> : public TrueValue {};
-template <> struct IsIntegral<signed char> : public TrueValue {};
-template <> struct IsIntegral<unsigned char> : public TrueValue {};
-template <> struct IsIntegral<short> : public TrueValue {};
-template <> struct IsIntegral<unsigned short> : public TrueValue {};
-template <> struct IsIntegral<int> : public TrueValue {};
-template <> struct IsIntegral<unsigned int> : public TrueValue {};
-template <> struct IsIntegral<long> : public TrueValue {};
-template <> struct IsIntegral<unsigned long> : public TrueValue {};
-template <> struct IsIntegral<long long> : public TrueValue {};
-template <> struct IsIntegral<unsigned long long> : public TrueValue {};
-template <> struct IsIntegral<bool> : public TrueValue {};
-
-template <typename T> struct IsPointerType : public FalseValue {};
-template <typename T> struct IsPointerType<T *> : public TrueValue {};
+template <typename T> struct TypeIdentity { typedef T Type; };
 
 template <typename T1, typename T2> struct IsSame : public FalseValue {};
 template <typename T> struct IsSame<T, T> : public TrueValue {};
-
-template <typename T> struct TypeIdentity { typedef T Type; };
+template <typename T1, typename T2>
+constexpr bool IsSameV = IsSame<T1, T2>::Value;
 
 template <typename T> struct RemoveCV : public TypeIdentity<T> {};
 template <typename T> struct RemoveCV<const T> : public TypeIdentity<T> {};
@@ -56,6 +41,28 @@
 
 template <typename T> using RemoveCVType = typename RemoveCV<T>::Type;
 
+template <typename Type> struct IsIntegral {
+  static constexpr bool Value =
+      IsSameV<char, RemoveCVType<Type>> ||
+      IsSameV<signed char, RemoveCVType<Type>> ||
+      IsSameV<unsigned char, RemoveCVType<Type>> ||
+      IsSameV<short, RemoveCVType<Type>> ||
+      IsSameV<unsigned short, RemoveCVType<Type>> ||
+      IsSameV<int, RemoveCVType<Type>> ||
+      IsSameV<unsigned int, RemoveCVType<Type>> ||
+      IsSameV<long, RemoveCVType<Type>> ||
+      IsSameV<unsigned long, RemoveCVType<Type>> ||
+      IsSameV<long long, RemoveCVType<Type>> ||
+      IsSameV<unsigned long long, RemoveCVType<Type>> ||
+      IsSameV<bool, RemoveCVType<Type>>;
+};
+
+template <typename T> struct IsPointerTypeNoQual : public FalseValue {};
+template <typename T> struct IsPointerTypeNoQual<T *> : public TrueValue {};
+template <typename T> struct IsPointerType {
+  static constexpr bool Value = IsPointerTypeNoQual<RemoveCVType<T>>::Value;
+};
+
 template <typename Type> struct IsFloatingPointType {
   static constexpr bool Value = IsSame<float, RemoveCVType<Type>>::Value ||
                                 IsSame<double, RemoveCVType<Type>>::Value ||


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83980.278634.patch
Type: text/x-patch
Size: 2991 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20200716/44307ab3/attachment-0001.bin>