[libc-commits] [PATCH] D82997: Add implementations of fmin and fminf

[Tue Ly via Phabricator via libc-commits]

lntue marked 5 inline comments as done.
lntue added inline comments.


================
Comment at: libc/test/src/math/fminl_test.cpp:26
+#define GET_BITS(LD_VALUE)                                                     \
+  static_cast<unsigned long long>(FPBits(LD_VALUE).bitsAsUInt())
+
----------------
sivachandra wrote:
> Wouldn't casting to `unsigned long long` lead to truncation? If you actually feel strongly about this setup, I would suggest adding an `__uint128` overload to `EXPECT_EQ` and friends.
EXPECT_EQ and friends are now updated to accept __uint128 and floating point types.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82997/new/

https://reviews.llvm.org/D82997