[libc-commits] [PATCH] D83380: [libc][benchmark] Add display option to render.py3

Guillaume Chatelet via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Jul 9 02:05:44 PDT 2020


gchatelet requested changes to this revision.
gchatelet added inline comments.
This revision now requires changes to proceed.


================
Comment at: libc/benchmarks/render.py3:134
+              if display == "cycles":
+                  value = value * root["Host"]["CpuFrequency"]
+              if display == "bytespercycle":
----------------
Python being what it is would you mind hoisting `root["Host"]["CpuFrequency"]` out of the for loops?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83380/new/

https://reviews.llvm.org/D83380





More information about the libc-commits mailing list