[libc-commits] [PATCH] D82846: [libc] Add documentation for clang-tidy checks.
Siva Chandra via Phabricator via libc-commits
libc-commits at lists.llvm.org
Mon Jul 6 12:22:08 PDT 2020
sivachandra added a comment.
One inline comment, but overall LGTM.
================
Comment at: libc/docs/clang_tidy_checks.rst:31
+An advantage of writing a libc in C++ is the ability to use namespaces in our
+implementation. However, implemented entry points must be included within the
+correct namespace in order to export the C symbols properly. Without a formal
----------------
I think the wording and examples should talk about the general case that all implementation pieces should be under the __llvm_libc namespace.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82846/new/
https://reviews.llvm.org/D82846
More information about the libc-commits
mailing list