[libc-commits] [PATCH] D73668: [libc] Add [EXPECT|ASSERT]_[TRUE|FALSE] unittest macros.

Guillaume Chatelet via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Jan 31 01:18:14 PST 2020


gchatelet marked an inline comment as done.
gchatelet added a comment.

Thx!



================
Comment at: libc/utils/UnitTest/Test.h:66-67
   // of type promotion.
-  template <
-      typename ValType,
-      cpp::EnableIfType<cpp::IsIntegralNotBool<ValType>::Value, ValType> = 0>
+  template <typename ValType,
+            cpp::EnableIfType<cpp::IsIntegral<ValType>::Value, ValType> = 0>
   static bool test(RunContext &Ctx, TestCondition Cond, ValType LHS,
----------------
abrachet wrote:
> @gchatelet will be happy about this change :)
woohoo \O/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73668/new/

https://reviews.llvm.org/D73668





More information about the libc-commits mailing list