[libc-commits] [PATCH] D73472: [libc] Add utils for memory functions
Siva Chandra via Phabricator via libc-commits
libc-commits at lists.llvm.org
Mon Jan 27 15:04:49 PST 2020
sivachandra added inline comments.
================
Comment at: libc/src/CMakeLists.txt:4
add_subdirectory(string)
+add_subdirectory(memory)
# TODO: Add this target conditional to the target OS.
----------------
Sorry, I did not catch it in the first pass: I think the memory functions are declared in `string.h`. In which case, you should not be adding a new directory called `memory`, but make use of the existing `string` directory.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73472/new/
https://reviews.llvm.org/D73472
More information about the libc-commits
mailing list