[libc-commits] [PATCH] D73472: [libc] Add utils for memory functions

[Fangrui Song via Phabricator via libc-commits]

MaskRay added inline comments.


================
Comment at: libc/src/memory/utils.h:14-15
+
+#include <stddef.h>
+#include <stdint.h>
+
----------------
abrachet wrote:
> We'll need to wait for @sivachandra for this one, because I really don't know. But look how mman.h gets size_t, https://github.com/llvm/llvm-project/blob/master/libc/config/linux/api.td#L7 
> https://github.com/llvm/llvm-project/blob/master/libc/config/linux/api.td#L106
> I don't think this internal header needs to go through the same process but we don't have `stddef` or `stdint`, and I think we stopped including library headers like this.
> 
> Also for @sivachandra the definition of `size_t` includes `stddef` is that ok?
stddef.h is ok. Several headers define size_t, but that list does not include stdint.h . So, yes, we need stddef.h


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73472/new/

https://reviews.llvm.org/D73472