[libc-commits] [PATCH] D72516: [llvm-libc] Add memory function benchmarks

[Guillaume Chatelet via Phabricator via libc-commits]

gchatelet added inline comments.


================
Comment at: libc/cmake/modules/LLVMLibCRules.cmake:320
   foreach(dep IN LISTS LIBC_UNITTEST_DEPENDS)
-    get_target_property(dep_type ${dep} "TARGET_TYPE")
-    if (dep_type)
-      string(COMPARE EQUAL ${dep_type} ${ENTRYPOINT_OBJ_TARGET_TYPE} dep_is_entrypoint)
+    get_property(dep_target_type TARGET ${dep} PROPERTY "TARGET_TYPE")
+    if (dep_target_type)
----------------
sivachandra wrote:
> sivachandra wrote:
> > Do we still need the changes in this file?
> Pointing out again: The changes in this file are OK, but if they are not required for the rest of the change, they should probably be done separately.
Thx for your comment. I'm reverting this file but note that compiling `llvm-libc` with shared libraries still fails because of a missing `LINK_COMPONENTS Support` in `libc/utils/UnitTest/CMakeLists.txt`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72516/new/

https://reviews.llvm.org/D72516