[libc-commits] [PATCH] D72516: [llvm-libc] Add memory function benchmarks

[Guillaume Chatelet via Phabricator via libc-commits]

gchatelet added inline comments.


================
Comment at: libc/utils/benchmarks/render.py:8
+Run:
+> python3 render.py <files>
+
----------------
sivachandra wrote:
> The instructions here and in README.md imply that the script is Python3 only. I tried with Python 2 and it seems to work. More important though:
> 
> 
>   # If you want it to be Python 3 only, probably say it here and in README.md.
>   # The CMake rule which runs this script runs `python` and not `python3`. Again, if you want this script to be Python 3 only going forward, then use `python3` in the CMake rule as well.
`Python2` is [officially deprecated](https://www.python.org/doc/sunset-python-2/) so it has to be `Python3` :)

I've changed the file extension and updated the `README.md` file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72516/new/

https://reviews.llvm.org/D72516