[libc-commits] [PATCH] D72516: [llvm-libc] Add memory function benchmarks

[Siva Chandra via Phabricator via libc-commits]

sivachandra added a comment.

This change is fine with me. I will let @ckennelly approve it. A nit inline, and also, is RATIONALE.md still missing?



================
Comment at: libc/utils/benchmarks/render.py:8
+Run:
+> python3 render.py <files>
+
----------------
The instructions here and in README.md imply that the script is Python3 only. I tried with Python 2 and it seems to work. More important though:


  # If you want it to be Python 3 only, probably say it here and in README.md.
  # The CMake rule which runs this script runs `python` and not `python3`. Again, if you want this script to be Python 3 only going forward, then use `python3` in the CMake rule as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72516/new/

https://reviews.llvm.org/D72516