[libc-commits] [PATCH] D72516: [llvm-libc] Add memory function benchmarks

[Guillaume Chatelet via Phabricator via libc-commits]

gchatelet updated this revision to Diff 237941.
gchatelet marked 19 inline comments as done.
gchatelet added a comment.

- Fix JSON comments and tests
- Fix missing comments trailing dot
- Fix enum case
- Moved NDEBUG warning to main
- Removed unneeded inline keyword
- Remove function pointer dereferencing
- Used regular EXPECT wherever possible


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72516/new/

https://reviews.llvm.org/D72516

Files:
  libc/cmake/modules/LLVMLibCRules.cmake
  libc/utils/CMakeLists.txt
  libc/utils/HdrGen/CMakeLists.txt
  libc/utils/benchmarks/CMakeLists.txt
  libc/utils/benchmarks/JSON.cpp
  libc/utils/benchmarks/JSON.h
  libc/utils/benchmarks/JSONTest.cpp
  libc/utils/benchmarks/LibcBenchmark.cpp
  libc/utils/benchmarks/LibcBenchmark.h
  libc/utils/benchmarks/LibcBenchmarkTest.cpp
  libc/utils/benchmarks/LibcMemoryBenchmark.cpp
  libc/utils/benchmarks/LibcMemoryBenchmark.h
  libc/utils/benchmarks/LibcMemoryBenchmarkMain.cpp
  libc/utils/benchmarks/LibcMemoryBenchmarkMain.h
  libc/utils/benchmarks/LibcMemoryBenchmarkTest.cpp
  libc/utils/benchmarks/Memcmp.cpp
  libc/utils/benchmarks/Memcpy.cpp
  libc/utils/benchmarks/Memset.cpp
  libc/utils/benchmarks/README.md
  libc/utils/benchmarks/configuration_big.json
  libc/utils/benchmarks/configuration_small.json
  libc/utils/benchmarks/render.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72516.237941.patch
Type: text/x-patch
Size: 82823 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20200114/98799945/attachment-0001.bin>