[libc-commits] [libc] c2dcdf9 - [libc] Fix benchmarks CMakeLists.txt

[Guillaume Chatelet via libc-commits]

Author: Guillaume Chatelet
Date: 2020-01-29T15:56:47+01:00
New Revision: c2dcdf95eba0d8210bf456821b8afff9b22a7bc9

URL: https://github.com/llvm/llvm-project/commit/c2dcdf95eba0d8210bf456821b8afff9b22a7bc9
DIFF: https://github.com/llvm/llvm-project/commit/c2dcdf95eba0d8210bf456821b8afff9b22a7bc9.diff

LOG: [libc] Fix benchmarks CMakeLists.txt

Summary:
This is a follow up on https://reviews.llvm.org/rGaba80d0734d1#886881.
`target_link_options` requires CMake>=3.13.

Reviewers: abrachet

Subscribers: mgorny, MaskRay, tschuett, libc-commits

Tags: #libc-project

Differential Revision: https://reviews.llvm.org/D73452

Added: 
    

Modified: 
    libc/utils/benchmarks/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/libc/utils/benchmarks/CMakeLists.txt b/libc/utils/benchmarks/CMakeLists.txt
index 84804842b64e..d5926d67ab68 100644
--- a/libc/utils/benchmarks/CMakeLists.txt
+++ b/libc/utils/benchmarks/CMakeLists.txt
@@ -91,9 +91,17 @@ add_library(libc-benchmark
     LibcBenchmark.h
 )
 add_dependencies(libc-benchmark google-benchmark)
-target_include_directories(libc-benchmark PUBLIC "${GOOGLE_BENCHMARK_LIBC_INSTALL}/include")
-target_link_options(libc-benchmark PUBLIC "${GOOGLE_BENCHMARK_LINK_FLAGS}")
-target_link_libraries(libc-benchmark PUBLIC LLVMSupport -lbenchmark Threads::Threads)
+target_include_directories(libc-benchmark
+    PUBLIC
+    "${GOOGLE_BENCHMARK_LIBC_INSTALL}/include"
+)
+target_link_libraries(libc-benchmark
+    PUBLIC
+    "${GOOGLE_BENCHMARK_LINK_FLAGS}" # FIXME: Move to `target_link_options`
+    -lbenchmark                      # FIXME: Move to `target_link_options`
+    LLVMSupport
+    Threads::Threads
+)
 fix_rtti(libc-benchmark)
 
 add_libc_benchmark_unittest(libc-benchmark-test