[libc-commits] [PATCH] D73530: [libc] Add a library of standalone C++ utilities.

[Alex Brachet via Phabricator via libc-commits]

abrachet added inline comments.


================
Comment at: libc/utils/UnitTest/Test.h:21
 // a TRUE or FALSE condition. That is because, C library funtions do not
 // return, but use integral return values to indicate true or false
 // conditions. Hence, it is more appropriate to use the other comparison
----------------
Now that I see it again, I think this should say "return bool" or "return _Bool" 


================
Comment at: libc/utils/UnitTest/Test.h:68
+      typename ValType,
+      cpp::EnableIfType<cpp::IsIntegralNotBool<ValType>::Value, ValType> = 0>
   static bool test(RunContext &Ctx, TestCondition Cond, ValType LHS,
----------------
gchatelet wrote:
> Can we have an `explicit` specialization that handles comparing two `bool`?
 https://reviews.llvm.org/D73472#inline-667032 and line 20 of this file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73530/new/

https://reviews.llvm.org/D73530