[libc-commits] [libc] 2c1a142 - Fix missing dependency in LibcUnitTest

[Guillaume Chatelet via libc-commits]

Author: Guillaume Chatelet
Date: 2020-01-27T10:14:39+01:00
New Revision: 2c1a142a78ffe8ed06fd7bfd17750afdceeaecc9

URL: https://github.com/llvm/llvm-project/commit/2c1a142a78ffe8ed06fd7bfd17750afdceeaecc9
DIFF: https://github.com/llvm/llvm-project/commit/2c1a142a78ffe8ed06fd7bfd17750afdceeaecc9.diff

LOG: Fix missing dependency in LibcUnitTest

Summary: LibcUnitTest is missing a dependency on LLVMSupport. This prevents building with shared libraries.

Reviewers: sivachandra

Subscribers: mgorny, MaskRay, libc-commits

Tags: #libc-project

Differential Revision: https://reviews.llvm.org/D73337

Added: 
    

Modified: 
    libc/cmake/modules/LLVMLibCRules.cmake
    libc/utils/UnitTest/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/libc/cmake/modules/LLVMLibCRules.cmake b/libc/cmake/modules/LLVMLibCRules.cmake
index 34b10cc421b9..cef667313c61 100644
--- a/libc/cmake/modules/LLVMLibCRules.cmake
+++ b/libc/cmake/modules/LLVMLibCRules.cmake
@@ -356,7 +356,7 @@ function(add_libc_unittest target_name)
     gtest
   )
 
-  target_link_libraries(${target_name} PRIVATE LibcUnitTest LLVMSupport)
+  target_link_libraries(${target_name} PRIVATE LibcUnitTest)
 
   add_custom_command(
     TARGET ${target_name}

diff  --git a/libc/utils/UnitTest/CMakeLists.txt b/libc/utils/UnitTest/CMakeLists.txt
index 2a1f9723057d..9d1ea10af6fd 100644
--- a/libc/utils/UnitTest/CMakeLists.txt
+++ b/libc/utils/UnitTest/CMakeLists.txt
@@ -2,4 +2,5 @@ add_llvm_library(
   LibcUnitTest
   Test.cpp
   Test.h
+  LINK_COMPONENTS Support
 )