[libc-commits] [PATCH] D73337: Fix missing dependency in LibcUnitTest

Sat Jan 25 02:08:15 PST 2020

gchatelet added a comment.

In D73337#1839664 <https://reviews.llvm.org/D73337#1839664>, @sivachandra wrote:

> Sorry, I take my acceptance back. I do not think this is required. If you rebase to HEAD of master, it should work without this change. I think, when you reverted the changes to LLVMLibCRules.cmake, you removed LLVMSupport from the list of link libraries for add_libc_unittest targets.

No this is required, compiling a fresh `origin/master` leads to a bunch of errors of the style

  ld.lld: error: undefined symbol: llvm::raw_ostream::operator<<(unsigned long long)
  >>> referenced by Test.cpp:46 (/redacted/llvm-project/libc/utils/UnitTest/Test.cpp:46)
  >>>               projects/libc/utils/UnitTest/CMakeFiles/LibcUnitTest.dir/Test.cpp.o:(bool llvm_libc::testing::internal::test<unsigned long long>(llvm_libc::testing::RunContext&, llvm_libc::testing::TestCondition, unsigned long long, unsigned long long, char const*, char const*, char const*, unsigned long))

This is because the library itself depends on Support to be able to be linked.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73337/new/

https://reviews.llvm.org/D73337