[libc-commits] [PATCH] D72516: [llvm-libc] Add memory function benchmarks

[Siva Chandra via Phabricator via libc-commits]

sivachandra added a comment.

Just one comment in response to a comment. Will do a detailed review as soon as I can get to it.



================
Comment at: libc/utils/HdrGen/CMakeLists.txt:1
+set(LLVM_LINK_COMPONENTS Support)
+
----------------
abrachet wrote:
> Why was this not needed before? Or maybe a better question why is it needed now?
Apparently, this is required to build when configured with `-DBUILD_SHARED_LIBS=ON`. This is being used with other table-gen targets as well. For example: https://github.com/llvm/llvm-project/blob/master/clang/utils/TableGen/CMakeLists.txt


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72516/new/

https://reviews.llvm.org/D72516