[libc-commits] [PATCH] D72353: [libc] Add a convenience CMake rule to add testsuites.

[Siva Chandra via Phabricator via libc-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG880734aebb39: [libc] Add a convenience CMake rule to add testsuites. (authored by sivachandra).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72353/new/

https://reviews.llvm.org/D72353

Files:
  libc/cmake/modules/LLVMLibCRules.cmake
  libc/test/CMakeLists.txt
  libc/test/config/CMakeLists.txt
  libc/test/config/linux/CMakeLists.txt
  libc/test/config/linux/x86_64/CMakeLists.txt
  libc/test/src/errno/CMakeLists.txt
  libc/test/src/string/CMakeLists.txt
  libc/test/src/sys/mman/CMakeLists.txt


Index: libc/test/src/sys/mman/CMakeLists.txt
===================================================================
--- libc/test/src/sys/mman/CMakeLists.txt
+++ libc/test/src/sys/mman/CMakeLists.txt
@@ -1,5 +1,4 @@
-add_custom_target(libc_sys_mman_unittests)
-add_dependencies(check_libc libc_sys_mman_unittests)
+add_libc_testsuite(libc_sys_mman_unittests)
 
 add_libc_unittest(
   mmap_test
Index: libc/test/src/string/CMakeLists.txt
===================================================================
--- libc/test/src/string/CMakeLists.txt
+++ libc/test/src/string/CMakeLists.txt
@@ -1,5 +1,4 @@
-add_custom_target(libc_string_unittests)
-add_dependencies(check_libc libc_string_unittests)
+add_libc_testsuite(libc_string_unittests)
 
 add_libc_unittest(
   strcat_test
Index: libc/test/src/errno/CMakeLists.txt
===================================================================
--- libc/test/src/errno/CMakeLists.txt
+++ libc/test/src/errno/CMakeLists.txt
@@ -1,5 +1,4 @@
-add_custom_target(libc_errno_unittests)
-add_dependencies(check_libc libc_errno_unittests)
+add_libc_testsuite(libc_errno_unittests)
 
 add_libc_unittest(
   errno_test
Index: libc/test/config/linux/x86_64/CMakeLists.txt
===================================================================
--- libc/test/config/linux/x86_64/CMakeLists.txt
+++ libc/test/config/linux/x86_64/CMakeLists.txt
@@ -1,9 +1,6 @@
-add_custom_target(libc_linux_x86_64_tests)
-add_dependencies(libc_linux_tests libc_linux_x86_64_tests)
-
 add_libc_unittest(
   libc_linux_x86_64_syscall_unittest
-  SUITE libc_linux_x86_64_tests
+  SUITE libc_linux_tests
   SRCS syscall_test.cpp
   DEPENDS
    syscall_impl_h
Index: libc/test/config/linux/CMakeLists.txt
===================================================================
--- libc/test/config/linux/CMakeLists.txt
+++ libc/test/config/linux/CMakeLists.txt
@@ -1,4 +1,3 @@
-add_custom_target(libc_linux_tests)
-add_dependencies(check_libc libc_linux_tests)
+add_libc_testsuite(libc_linux_tests)
 
-add_subdirectory(x86_64)
+add_subdirectory(${LIBC_TARGET_MACHINE})
Index: libc/test/config/CMakeLists.txt
===================================================================
--- libc/test/config/CMakeLists.txt
+++ libc/test/config/CMakeLists.txt
@@ -1 +1 @@
-add_subdirectory(linux)
+add_subdirectory(${LIBC_TARGET_OS})
Index: libc/test/CMakeLists.txt
===================================================================
--- libc/test/CMakeLists.txt
+++ libc/test/CMakeLists.txt
@@ -1,4 +1,4 @@
-add_custom_target(check_libc)
+add_custom_target(check-libc)
 
 add_subdirectory(config)
 add_subdirectory(src)
Index: libc/cmake/modules/LLVMLibCRules.cmake
===================================================================
--- libc/cmake/modules/LLVMLibCRules.cmake
+++ libc/cmake/modules/LLVMLibCRules.cmake
@@ -371,3 +371,8 @@
     )
   endif()
 endfunction(add_libc_unittest)
+
+function(add_libc_testsuite suite_name)
+  add_custom_target(${suite_name})
+  add_dependencies(check-libc ${suite_name})
+endfunction(add_libc_testsuite)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72353.236768.patch
Type: text/x-patch
Size: 3031 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20200108/52b559cd/attachment.bin>